Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account_info add flags #812

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Account_info add flags #812

merged 2 commits into from
Aug 4, 2023

Conversation

cindyyan317
Copy link
Collaborator

Fix #768 and #767
Add flags to account_info

@cindyyan317 cindyyan317 marked this pull request as ready for review August 4, 2023 13:50
godexsoft
godexsoft previously approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! consider fixing the year on the copyright but everything else looks good 🥇

src/rpc/Amendments.h Outdated Show resolved Hide resolved
unittests/rpc/handlers/AccountInfoTest.cpp Show resolved Hide resolved
godexsoft
godexsoft approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@cindyyan317 cindyyan317 merged commit d61d702 into XRPLF:develop Aug 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godexsoft godexsoft godexsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add disallowIncoming* flag to account_info response after upgrade protocol
3 participants
@cindyyan317 @godexsoft @thejohnfreeman